From: Carsten Schlote <schlote@vahanus.net>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH] ptxd_make_xpkg_pkg.sh: Prevent empty comp variable
Date: Mon, 9 Dec 2024 17:07:40 +0100 [thread overview]
Message-ID: <0290f0e5-3910-4f33-bf43-6bf4f012f710@vahanus.net> (raw)
Changed code to detect broken detection and to prevent an invalid comp
variable ('=').
It will be set to com="" in this case.
The target objcopy tool will use its internal default for compression in
this case.
Signed-off-by: Carsten Schlote <schlote@vahanus.net>
---
scripts/lib/ptxd_make_xpkg_pkg.sh | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/scripts/lib/ptxd_make_xpkg_pkg.sh
b/scripts/lib/ptxd_make_xpkg_pkg.sh
index 08a0ab593..36bb3a564 100644
--- a/scripts/lib/ptxd_make_xpkg_pkg.sh
+++ b/scripts/lib/ptxd_make_xpkg_pkg.sh
@@ -390,11 +390,15 @@ ptxd_install_compression_format() {
libc="$(ptxd_cross_cc -print-file-name=libc.so.6 2> /dev/null)"
if [ -n "${libc}" ]; then
- comp="=$(readelf -t "${libc}" | sed -n -e
'/COMPRESSED/{N;s/.*\(ZLIB\|ZSTD\).*/\1/p;q}' | tr '[:upper:]' '[:lower:]')"
+ comp="=$(readelf -t "${libc}" | sed -n -e
'/COMPRESSED/{N;s/.*\(ZLIB\|ZSTD\).*/\1/p;q}' | tr '[:upper:]' '[:lower:]')"
+ fi
+ if [ "${comp}" == "=" ]; then
+ comp=""
fi
export ptxd_install_file_objcopy_args="--only-keep-debug
--compress-debug-sections${comp}"
}
+
ptxd_install_compression_format
ptxd_install_file_extract_debug() {
--
2.47.1
reply other threads:[~2024-12-11 10:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0290f0e5-3910-4f33-bf43-6bf4f012f710@vahanus.net \
--to=schlote@vahanus.net \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox