From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Johannes Zink <j.zink@pengutronix.de>, distrokit@pengutronix.de
Cc: patchwork-jzi@pengutronix.de
Subject: Re: [DistroKit] [PATCH 3/5] v8a: images: generate sparse images from rock3a initramfs, kernel and dtb
Date: Thu, 8 Jun 2023 09:28:50 +0200 [thread overview]
Message-ID: <feadb819-c30a-ee6b-11ab-232e7696195c@pengutronix.de> (raw)
In-Reply-To: <2a9d6033-3ab0-70ac-6b27-072e9af2f6ef@pengutronix.de>
On 06.06.23 17:26, Ahmad Fatoum wrote:
> On 06.06.23 17:04, Johannes Zink wrote:
>> On 6/6/23 16:51, Ahmad Fatoum wrote:
>>> On 06.06.23 16:47, Johannes Zink wrote:
>>> Can you describe how to reproduce this with a normal DistroKit build?
>>
>> sure, just apply this series (or at least patch 1/5 for initrd generation), run ptxdist images and expose a fastboot partition on the DUT by calling
>>
>> usbgadget -A /tmp/initramfs(initramfs)c
>>
>> then use fastboot to upload the cpio.gz from your distrokit build dir
>>
>> fastboot flash initramfs platform-v8a/images/initramfs-sparse.img
>
> I can reproduce this with fastboot version 28.0.2-debian.
> It wasn't always like that. I assume -S 0 wasn't always the
> default, but I haven't checked the code. I think it's worth a bug
> report.
I gave this a try and I am not so sure anymore this is a bug. Small images
are uploaded without problem. This cut off seems to be 8M.
Above 8M, transferred file size is rounded up to be a multiple of 4096 bytes.
Files that are not aligned and bigger than 8M trigger the issue.
I assume we had not noticed this before because we either flash disk images
which are 4K aligned or we flash small images which were < 8M.
I haven't looked into the fastboot client code, but a look would be worthwhile
to decide how to proceed.
>>>> It saves upload time anyway, at least for the initramfs, so it's a good idea to use sparse images, anyway.
>>>
>>> Sparse is a compression algorithm, albeit a very primitive one. Your kernel and
>>> initrd should already be compressed, so if you have savings from compressing
>>> them again with sparse, there's something wrong IMO.
>>>
>>> The device tree is small enough that it shouldn't matter.
>
> As mentioned, I don't think double compression is useful.
> On our side, we can likely just use -S 1 to restore the old behavior.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-06-08 7:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 14:31 [DistroKit] [PATCH 0/5] enable uploading kernel, dtb and initramfs over fastboot and boot it on Rock3A Johannes Zink
2023-06-06 14:31 ` [DistroKit] [PATCH 1/5] v8a: enable initrd generation Johannes Zink
2023-06-06 14:37 ` Ahmad Fatoum
2023-06-06 14:44 ` Johannes Zink
2023-06-06 14:59 ` Jan Lübbe
2023-06-06 15:02 ` Johannes Zink
2023-06-06 14:31 ` [DistroKit] [PATCH 2/5] v8a: kernel: enable initramfs in kernel config Johannes Zink
2023-06-06 14:37 ` Ahmad Fatoum
2023-06-06 14:31 ` [DistroKit] [PATCH 3/5] v8a: images: generate sparse images from rock3a initramfs, kernel and dtb Johannes Zink
2023-06-06 14:41 ` Ahmad Fatoum
2023-06-06 14:42 ` Ahmad Fatoum
2023-06-06 14:49 ` Johannes Zink
2023-06-06 14:54 ` Ahmad Fatoum
2023-06-06 14:47 ` Johannes Zink
2023-06-06 14:51 ` Ahmad Fatoum
2023-06-06 15:04 ` Johannes Zink
2023-06-06 15:26 ` Ahmad Fatoum
2023-06-08 7:28 ` Ahmad Fatoum [this message]
2023-06-06 14:31 ` [DistroKit] [PATCH 4/5] v8a: barebox: enable loading kernel, dtb and initrd via fastboot Johannes Zink
2023-06-06 14:44 ` Ahmad Fatoum
2023-06-06 14:54 ` Johannes Zink
2023-06-08 7:36 ` Ahmad Fatoum
2023-06-09 6:26 ` Johannes Zink
2023-06-06 15:04 ` Jan Lübbe
2023-06-06 15:14 ` Johannes Zink
2023-06-06 15:16 ` Jan Lübbe
2023-06-06 14:31 ` [DistroKit] [PATCH 5/5] v8a: barebox: add a boot target for fastboot loaded image files Johannes Zink
2023-06-06 14:47 ` Ahmad Fatoum
2023-06-06 15:07 ` Jan Lübbe
2023-06-06 15:13 ` Johannes Zink
2023-06-09 9:53 ` Johannes Zink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feadb819-c30a-ee6b-11ab-232e7696195c@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=distrokit@pengutronix.de \
--cc=j.zink@pengutronix.de \
--cc=patchwork-jzi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox