Re: [DistroKit] [PATCH 03/11] v7a: barebox: boot from bootsource

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 5/26/25 12:11, Roland Hieber wrote:
> Barebox 2025.05.0 with CONFIG_BOOT_DEFAULTS (which we implicitly
> enabled in the last commit) can resolve the boot target "bootsource" to
> the device from which the board was initially booted, if this is
> supported by the platform code (see barebox commit 6d91022db295 "common:
> bootdef: add new boot entry provider" for more info). This way we won't
> have to hard-code "mmc0", "mmc2", or "disk0" as the boot target for
> different platforms.
> 
> Link: https://git.pengutronix.de/cgit/barebox/commit/?id=6d91022db29555c175e9
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  .../platform-v7a/barebox-defaultenv/nv/bootchooser.system0.boot | 2 +-
>  .../platform-v7a/barebox-defaultenv/nv/bootchooser.system1.boot | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/platform-v7a/barebox-defaultenv/nv/bootchooser.system0.boot b/configs/platform-v7a/barebox-defaultenv/nv/bootchooser.system0.boot
> index c0c541c8b2a3..5ec387df9ea0 100644
> --- a/configs/platform-v7a/barebox-defaultenv/nv/bootchooser.system0.boot
> +++ b/configs/platform-v7a/barebox-defaultenv/nv/bootchooser.system0.boot
> @@ -1 +1 @@
> -mmc0.root-A
> + bootsource.root-A

I guess it doesn't matter, but what's up with the space here?

Cheers,
Ahmad

> diff --git a/configs/platform-v7a/barebox-defaultenv/nv/bootchooser.system1.boot b/configs/platform-v7a/barebox-defaultenv/nv/bootchooser.system1.boot
> index 1d40e339c2fe..cea618acf89a 100644
> --- a/configs/platform-v7a/barebox-defaultenv/nv/bootchooser.system1.boot
> +++ b/configs/platform-v7a/barebox-defaultenv/nv/bootchooser.system1.boot
> @@ -1 +1 @@
> -mmc0.root-B
> + bootsource.root-B

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |