From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 26 May 2025 11:57:27 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uJUaF-000Tzy-1M for lore@lore.pengutronix.de; Mon, 26 May 2025 11:57:27 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uJUaE-0006qZ-L2; Mon, 26 May 2025 11:57:26 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uJUaA-0006pO-EA; Mon, 26 May 2025 11:57:22 +0200 Message-ID: Date: Mon, 26 May 2025 11:57:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Alexander Dahl , distrokit@pengutronix.de References: <20250523135815.2998753-1-ada@thorsis.com> Content-Language: en-US, de-DE From: Lars Schmidt In-Reply-To: <20250523135815.2998753-1-ada@thorsis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH v2 0/4] platform: v8a: barebox: Untangle firmware inject files X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hi Alex, it's a good idea to separate these changes from the rest of my patch series and get all the firmware dependencies between barebox and tf-a sorted out in one shot. I would change my patches accordingly once yours got merged. You solved select in the BAREBOX_DEPENDENCIES to select the corresponding Firmware packages more elegantly. Referring to your previous message 20250523-oxidation-impatient-e4414c0099c8@thorsis.com in my patches: I think the question where the injection of the firmware blobs go is just two different ways to approach the problem. In my opinion, the firmware blobs (which are getting injected into barebox) belong to their corresponding firmware packages and inject files into barebox. If in the future anything with those firmware packages changes, like the blobs getting renamed, moved or disappear, it is easier to figure out what else needs to be changed. So think it would be better that these injections are connected to their corresponding firmware and not to barebox, and thus get named named firmwarename.barebox.* I think this could make future maintenance easier. In the end it's just two different approaches and both have their valid reason. So I'd be fine with your solution, too. Greetings Lars On 23.05.25 15:58, Alexander Dahl wrote: > Hello Lars, everyone, > > this is a one year later series with previously dropped patches from > another series, and basically a follow-up to those mails: > > - <20240425-unlivable-approval-c55177db2d5c@thorsis.com> > - <20250523081049.1693633-6-l.schmidt@pengutronix.de> > > Picking this up now, because this was almost ready last year already, > but I did not manage to rework it for resubmission. Not meant to be > rude, but maybe suitable for discussing the right approach of firmware > injection into different bootloader packages. > > When having another look, I think it was correct to drop v1, I did not > go far enough with the first shot. This is done now by patch 3/4 which > separates the imx-firmware injects from the tf-a injects into separate > fixup packages for barebox. Patch 4/4 picks up an idea by Lars, please > let me know when this should be attributed differently. > > Note, this is in conflict with the series "[PATCH 00/12] Add beagleplay > support to DistroKit" sent earlier this week. > > Build tested twice on vanilla DistroKit _and_ in a custom BSP using > DistroKit as a base layer and disabling most DistroKit boards. Upper > layer builds U-Boot for three different i.MX8/9 based boards, depending > on both firmware-imx and tf-a. > > v2: > - 6 out of 9 patches from original series applied, series renamed > - rebased remaining patches to master > - reworked patch 3/4 to also break out tf-a, not only firmware-imx > - added new patch 4/4 to not inject all tf-a artifacts unconditionally > > v1: > - Link: https://lore.distrokit.org/distrokit/20240425080303.171897-1-ada@thorsis.com/ > > Greets > Alex > > Alexander Dahl (4): > platform: v8a: firmware-rockchip: Move barebox injects to separate > package > platform: v8a: barebox: Remove extra host prog > platform: v8a: firmware-imx: Break out barebox injects to separate > packages > platform: v8a: barebox: Inject tf-a binaries conditionally > > configs/platform-v8a/platformconfig | 3 ++ > configs/platform-v8a/platforms/barebox.imx.in | 12 ++++++++ > .../platforms/barebox.rockchip.in | 14 +++++++++ > .../platform-v8a/platforms/barebox.tf-a.in | 11 +++++++ > .../platform-v8a/platforms/firmware-imx.in | 6 ---- > .../platforms/firmware-rockchip.in | 5 ---- > configs/platform-v8a/rules/barebox.imx.make | 22 ++++++++++++++ > .../platform-v8a/rules/barebox.rockchip.make | 21 ++++++++++++-- > configs/platform-v8a/rules/barebox.tf-a.make | 29 +++++++++++++++++++ > configs/platform-v8a/rules/firmware-imx.make | 21 -------------- > .../platform-v8a/rules/firmware-rockchip.make | 10 ------- > 11 files changed, 110 insertions(+), 44 deletions(-) > create mode 100644 configs/platform-v8a/platforms/barebox.imx.in > create mode 100644 configs/platform-v8a/platforms/barebox.rockchip.in > create mode 100644 configs/platform-v8a/platforms/barebox.tf-a.in > create mode 100644 configs/platform-v8a/rules/barebox.imx.make > create mode 100644 configs/platform-v8a/rules/barebox.tf-a.make > > > base-commit: 89e05d18da5c3a064013b7ae7cdaa3f44ab307c1