From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 25 Mar 2026 14:10:16 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w5O00-004vob-1P for lore@lore.pengutronix.de; Wed, 25 Mar 2026 14:10:16 +0100 Received: from [127.0.0.1] (helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1w5O00-00055a-0C; Wed, 25 Mar 2026 14:10:16 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w5Nzv-00055K-1E; Wed, 25 Mar 2026 14:10:11 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w5Nzu-00241L-2j; Wed, 25 Mar 2026 14:10:10 +0100 Received: from rsc by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1w5Nzu-00000004nRx-3A0S; Wed, 25 Mar 2026 14:10:10 +0100 Date: Wed, 25 Mar 2026 14:10:10 +0100 From: Robert Schwebel To: Ahmad Fatoum Message-ID: References: <20260325114133.2238715-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260325114133.2238715-1-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [DistroKit] [PATCH 1/2] reason: correctly allow CONFIG_BOOTM_OFTREE_FALLBACK X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false applied series to next On Wed, Mar 25, 2026 at 12:41:29PM +0100, Ahmad Fatoum wrote: > The QA override couldn't work for several reasons: > > - We set CONFIG_NAME to different values like e.g. distrokit_v7a_old_defconfig > or distrokit_v8a_defconfig > > - barebox_oftree_fallback is not a boolean, so the override is > incorrect > > The argument in the override applies to all platforms, so let's fix > these issues and mandate CONFIG_BOOTM_OFTREE_FALLBACK=y independent > of the platforms. While at it, also fix a typo in the description. > > Signed-off-by: Ahmad Fatoum > --- > configs/bsp.ref | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/configs/bsp.ref b/configs/bsp.ref > index e8c33d259116..934c99c262c5 100644 > --- a/configs/bsp.ref > +++ b/configs/bsp.ref > @@ -46,15 +46,11 @@ barebox_oftree_fallback: > for use in production as DT binding breakage is not an infrequent > occurrence. > > - We take in DistroKit though to specify the DT when we specify a kernel, > - so enable this option as it's occasionally helpful for quick debugging. > - variants: > - - condition: | > - kconfig.have_barebox_config() and > - (kconfig.BareboxConfig()['CONFIG_NAME'] == "multi_v7_defconfig" or > - kconfig.BareboxConfig()['CONFIG_NAME'] == "multi_v8_defconfig") > - value: False > - - value: True > + We take care in DistroKit though to specify the DT when we specify > + a kernel, so enable this option as it's occasionally helpful for quick > + debugging. > + present: > + - BOOTM_OFTREE_FALLBACK > > barebox_arm_optimized_string_functions: > description: | > -- > 2.47.3 > > > -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |