From: Robert Schwebel <r.schwebel@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH 1/2] reason: correctly allow CONFIG_BOOTM_OFTREE_FALLBACK
Date: Wed, 25 Mar 2026 14:10:10 +0100 [thread overview]
Message-ID: <acPespP6H9uIwbdP@pengutronix.de> (raw)
In-Reply-To: <20260325114133.2238715-1-a.fatoum@pengutronix.de>
applied series to next
On Wed, Mar 25, 2026 at 12:41:29PM +0100, Ahmad Fatoum wrote:
> The QA override couldn't work for several reasons:
>
> - We set CONFIG_NAME to different values like e.g. distrokit_v7a_old_defconfig
> or distrokit_v8a_defconfig
>
> - barebox_oftree_fallback is not a boolean, so the override is
> incorrect
>
> The argument in the override applies to all platforms, so let's fix
> these issues and mandate CONFIG_BOOTM_OFTREE_FALLBACK=y independent
> of the platforms. While at it, also fix a typo in the description.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> configs/bsp.ref | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/configs/bsp.ref b/configs/bsp.ref
> index e8c33d259116..934c99c262c5 100644
> --- a/configs/bsp.ref
> +++ b/configs/bsp.ref
> @@ -46,15 +46,11 @@ barebox_oftree_fallback:
> for use in production as DT binding breakage is not an infrequent
> occurrence.
>
> - We take in DistroKit though to specify the DT when we specify a kernel,
> - so enable this option as it's occasionally helpful for quick debugging.
> - variants:
> - - condition: |
> - kconfig.have_barebox_config() and
> - (kconfig.BareboxConfig()['CONFIG_NAME'] == "multi_v7_defconfig" or
> - kconfig.BareboxConfig()['CONFIG_NAME'] == "multi_v8_defconfig")
> - value: False
> - - value: True
> + We take care in DistroKit though to specify the DT when we specify
> + a kernel, so enable this option as it's occasionally helpful for quick
> + debugging.
> + present:
> + - BOOTM_OFTREE_FALLBACK
>
> barebox_arm_optimized_string_functions:
> description: |
> --
> 2.47.3
>
>
>
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
prev parent reply other threads:[~2026-03-25 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 11:41 Ahmad Fatoum
2026-03-25 11:41 ` [DistroKit] [PATCH 2/2] barebox: update to v2026.03.1 Ahmad Fatoum
2026-03-25 13:10 ` Robert Schwebel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acPespP6H9uIwbdP@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=distrokit@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox