From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 12 Dec 2025 14:05:31 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vU2pv-00AflA-1g for lore@lore.pengutronix.de; Fri, 12 Dec 2025 14:05:31 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vU2pv-0007G1-5f; Fri, 12 Dec 2025 14:05:31 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vU2pp-0007FK-Gn; Fri, 12 Dec 2025 14:05:25 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vU2pp-005IVn-15; Fri, 12 Dec 2025 14:05:25 +0100 Received: from rsc by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1vU2pp-003HC8-0j; Fri, 12 Dec 2025 14:05:25 +0100 Date: Fri, 12 Dec 2025 14:05:25 +0100 From: Robert Schwebel To: Ahmad Fatoum Message-ID: References: <20251212123237.2636073-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251212123237.2636073-1-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [DistroKit] [PATCH] v7a: kernel: use 8250-based serial driver for OMAP X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Olbrich , distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Applied to next. On Fri, Dec 12, 2025 at 01:32:14PM +0100, Ahmad Fatoum wrote: > v6.18-rc1 introduced commit ca8be8fc2c ("ARM: dts: am33xx-l4: fix UART > compatible"), which changed the compatible for the serial device nodes > to satisfy a binding checker warning. > > Prior to that commit, there were two drivers that matched the UART > on the AM335x, but now there is only one and it's not the one we had > enabled in our kernel config. > > Enable the 8250 UART driver and disable the old one we no longer use. > As this changes the name of the UART devices from /dev/ttyO to /dev/ttyS > by default (unless the CONFIG_SERIAL_8250_OMAP_TTYO_FIXUP compatibility > option is enabled), we also enable CONFIG_DRIVER_SERIAL_NS16550_OMAP_TTYS > in barebox, so the correct TTY device is fixed up. > > Reported-by: Michael Olbrich > Signed-off-by: Ahmad Fatoum > --- > configs/platform-v7a/barebox-am335x-mlo.config | 2 +- > configs/platform-v7a/barebox.config | 2 +- > configs/platform-v7a/kernelconfig | 5 ++--- > 3 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/configs/platform-v7a/barebox-am335x-mlo.config b/configs/platform-v7a/barebox-am335x-mlo.config > index 0390ce03603a..964ad484b126 100644 > --- a/configs/platform-v7a/barebox-am335x-mlo.config > +++ b/configs/platform-v7a/barebox-am335x-mlo.config > @@ -247,7 +247,7 @@ CONFIG_OF_GPIO=y > # CONFIG_SERIAL_DEV_BUS is not set > # CONFIG_DRIVER_SERIAL_ARM_DCC is not set > CONFIG_DRIVER_SERIAL_NS16550=y > -# CONFIG_DRIVER_SERIAL_NS16550_OMAP_TTYS is not set > +CONFIG_DRIVER_SERIAL_NS16550_OMAP_TTYS=y > # CONFIG_DRIVER_SERIAL_CADENCE is not set > # CONFIG_SERIAL_SIFIVE is not set > # end of serial drivers > diff --git a/configs/platform-v7a/barebox.config b/configs/platform-v7a/barebox.config > index 94158ea58381..7c696f1f48e1 100644 > --- a/configs/platform-v7a/barebox.config > +++ b/configs/platform-v7a/barebox.config > @@ -724,7 +724,7 @@ CONFIG_SERIAL_AMBA_PL011=y > CONFIG_DRIVER_SERIAL_IMX=y > CONFIG_DRIVER_SERIAL_STM32=y > CONFIG_DRIVER_SERIAL_NS16550=y > -# CONFIG_DRIVER_SERIAL_NS16550_OMAP_TTYS is not set > +CONFIG_DRIVER_SERIAL_NS16550_OMAP_TTYS=y > # CONFIG_DRIVER_SERIAL_CADENCE is not set > # CONFIG_DRIVER_SERIAL_LPUART32 is not set > # CONFIG_SERIAL_SIFIVE is not set > diff --git a/configs/platform-v7a/kernelconfig b/configs/platform-v7a/kernelconfig > index f637dd7518ea..2985ce961e01 100644 > --- a/configs/platform-v7a/kernelconfig > +++ b/configs/platform-v7a/kernelconfig > @@ -1966,7 +1966,8 @@ CONFIG_SERIAL_8250_BCM2835AUX=y > CONFIG_SERIAL_8250_FSL=y > # CONFIG_SERIAL_8250_DW is not set > # CONFIG_SERIAL_8250_RT288X is not set > -# CONFIG_SERIAL_8250_OMAP is not set > +CONFIG_SERIAL_8250_OMAP=y > +# CONFIG_SERIAL_8250_OMAP_TTYO_FIXUP is not set > # CONFIG_SERIAL_OF_PLATFORM is not set > > # > @@ -1988,8 +1989,6 @@ CONFIG_SERIAL_IMX_CONSOLE=y > # CONFIG_SERIAL_UARTLITE is not set > CONFIG_SERIAL_CORE=y > CONFIG_SERIAL_CORE_CONSOLE=y > -CONFIG_SERIAL_OMAP=y > -CONFIG_SERIAL_OMAP_CONSOLE=y > # CONFIG_SERIAL_SIFIVE is not set > # CONFIG_SERIAL_SCCNXP is not set > # CONFIG_SERIAL_SC16IS7XX is not set > -- > 2.47.3 > > > -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |