DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Robert Schwebel <r.schwebel@pengutronix.de>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH] fixup! v8a: barebox-r5: clean up recipe
Date: Wed, 10 Dec 2025 14:09:40 +0100	[thread overview]
Message-ID: <aTlxFEAyvA_3xqE5@pengutronix.de> (raw)
In-Reply-To: <20251210121356.2492437-1-m.olbrich@pengutronix.de>

Squashed.

On Wed, Dec 10, 2025 at 01:13:56PM +0100, Michael Olbrich wrote:
> The commit changed ':=' to '='. That is not allowed if the variable
> references itself. The result is a recursion error.
> 
> Just merge the two declarations to avoid the recursion.
> ---
>  configs/platform-v8a/rules/barebox-r5.make | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/configs/platform-v8a/rules/barebox-r5.make b/configs/platform-v8a/rules/barebox-r5.make
> index c398e46da793..2d247d4eb3ec 100644
> --- a/configs/platform-v8a/rules/barebox-r5.make
> +++ b/configs/platform-v8a/rules/barebox-r5.make
> @@ -48,8 +48,7 @@ BAREBOX_R5_CONF_OPT	= \
>  
>  BAREBOX_R5_MAKE_OPT	= $(BAREBOX_R5_CONF_OPT)
>  
> -BAREBOX_R5_IMAGES := images/barebox-beagleplay-r5.img
> -BAREBOX_R5_IMAGES = $(addprefix $(BAREBOX_R5_BUILD_DIR)/,$(BAREBOX_R5_IMAGES))
> +BAREBOX_R5_IMAGES = $(BAREBOX_R5_BUILD_DIR)/images/barebox-beagleplay-r5.img
>  
>  ifdef PTXCONF_BAREBOX_R5
>  $(BAREBOX_R5_CONFIG):
> -- 
> 2.47.3
> 
> 
> 

-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |



  reply	other threads:[~2025-12-10 13:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 22:22 [DistroKit] [PATCH 1/6] v8a: barebox-r5: sync config file changes Roland Hieber
2025-12-05 22:22 ` [DistroKit] [PATCH 2/6] v8a: barebox-r5: clean up recipe Roland Hieber
2025-12-10 12:13   ` [DistroKit] [PATCH] fixup! " Michael Olbrich
2025-12-10 13:09     ` Robert Schwebel [this message]
2025-12-05 22:22 ` [DistroKit] [PATCH 3/6] v7a: at91bootstrap: version bump 4.0.6-rc1 -> 4.0.12 Roland Hieber
2025-12-08  9:22   ` Alexander Dahl
2025-12-05 22:22 ` [DistroKit] [PATCH 4/6] v8a: tf-a: make it compile with GCC 15 Roland Hieber
2025-12-05 22:22 ` [DistroKit] [PATCH 5/6] v8a: tf-a: re-export patch queue with 'git ptx-patches' Roland Hieber
2025-12-05 22:22 ` [DistroKit] [PATCH 6/6] toolchains: version bump 2024.11.1 -> 2025.11.0 Roland Hieber
2025-12-06 11:41 ` [DistroKit] [PATCH 1/6] v8a: barebox-r5: sync config file changes Robert Schwebel
2025-12-08 10:22   ` Roland Hieber
2025-12-08 10:27     ` Robert Schwebel
2025-12-08 10:52       ` Roland Hieber
2025-12-09 14:41     ` [DistroKit] [PATCH] fixup! toolchains: version bump 2024.11.1 -> 2025.11.0 Roland Hieber
2025-12-10  6:47       ` Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTlxFEAyvA_3xqE5@pengutronix.de \
    --to=r.schwebel@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=m.olbrich@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox