From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 24 Apr 2025 15:23:41 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u7wYH-004toT-1s for lore@lore.pengutronix.de; Thu, 24 Apr 2025 15:23:41 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1u7wYH-0003Hy-5I; Thu, 24 Apr 2025 15:23:41 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u7wYC-0003HF-4O; Thu, 24 Apr 2025 15:23:36 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u7wYB-001tF8-34; Thu, 24 Apr 2025 15:23:35 +0200 Received: from rsc by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1u7wYB-001N2C-2m; Thu, 24 Apr 2025 15:23:35 +0200 Date: Thu, 24 Apr 2025 15:23:35 +0200 From: Robert Schwebel To: Ahmad Fatoum Message-ID: References: <20250424113122.4141867-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424113122.4141867-1-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [DistroKit] [PATCH] v7a: barebox: am335x: make script hush-compatible X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Thu, Apr 24, 2025 at 01:31:22PM +0200, Ahmad Fatoum wrote: > Apparently, barebox' hush does support negation only in the test command > and not as part of the language. Invert the condition and remove the > early exit to fix the syntax error. > > Signed-off-by: Ahmad Fatoum Applied to next. > --- > .../barebox-defaultenv/init/usb-limit-1300 | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300 b/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300 > index 9801dd56c7e6..704b4452d5e3 100644 > --- a/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300 > +++ b/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300 > @@ -1,9 +1,7 @@ > #!/bin/sh > > -if ! of_compatible -k ti,am33xx; then > - exit > +if of_compatible -k ti,am33xx; then > + echo -n "changing USB current limit to 1300 mA... " > + i2c_write -b 0 -a 0x24 -r 0x01 0x3e > + echo "done" > fi > - > -echo -n "changing USB current limit to 1300 mA... " > -i2c_write -b 0 -a 0x24 -r 0x01 0x3e > -echo "done" > -- > 2.39.5 > > > -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |