[DistroKit] [PATCH] v7a: barebox: am335x: make script hush-compatible

[DistroKit] [PATCH] v7a: barebox: am335x: make script hush-compatible

[Ahmad Fatoum]

Apparently, barebox' hush does support negation only in the test command
and not as part of the language. Invert the condition and remove the
early exit to fix the syntax error.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 .../barebox-defaultenv/init/usb-limit-1300             | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300 b/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300
index 9801dd56c7e6..704b4452d5e3 100644
--- a/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300
+++ b/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300
@@ -1,9 +1,7 @@
 #!/bin/sh
 
-if ! of_compatible -k ti,am33xx; then
-	exit
+if of_compatible -k ti,am33xx; then
+	echo -n "changing USB current limit to 1300 mA... "
+	i2c_write -b 0 -a 0x24 -r 0x01 0x3e
+	echo "done"
 fi
-
-echo -n "changing USB current limit to 1300 mA... "
-i2c_write -b 0 -a 0x24 -r 0x01 0x3e
-echo "done"
-- 
2.39.5

Re: [DistroKit] [PATCH] v7a: barebox: am335x: make script hush-compatible

[Robert Schwebel]

On Thu, Apr 24, 2025 at 01:31:22PM +0200, Ahmad Fatoum wrote:
> Apparently, barebox' hush does support negation only in the test command
> and not as part of the language. Invert the condition and remove the
> early exit to fix the syntax error.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Applied to next.

> ---
>  .../barebox-defaultenv/init/usb-limit-1300             | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300 b/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300
> index 9801dd56c7e6..704b4452d5e3 100644
> --- a/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300
> +++ b/configs/platform-v7a/barebox-defaultenv/init/usb-limit-1300
> @@ -1,9 +1,7 @@
>  #!/bin/sh
>  
> -if ! of_compatible -k ti,am33xx; then
> -	exit
> +if of_compatible -k ti,am33xx; then
> +	echo -n "changing USB current limit to 1300 mA... "
> +	i2c_write -b 0 -a 0x24 -r 0x01 0x3e
> +	echo "done"
>  fi
> -
> -echo -n "changing USB current limit to 1300 mA... "
> -i2c_write -b 0 -a 0x24 -r 0x01 0x3e
> -echo "done"
> -- 
> 2.39.5
> 
> 
> 

-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |