From: Robert Schwebel <r.schwebel@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH 1/3] v7a: barebox: defaultenv: delete no-op init scripts
Date: Tue, 22 Apr 2025 11:24:31 +0200 [thread overview]
Message-ID: <aAdgT7yisK0loixs@pengutronix.de> (raw)
In-Reply-To: <20250414102850.3164387-1-a.fatoum@pengutronix.de>
Series applied to next.
On Mon, Apr 14, 2025 at 12:28:48PM +0200, Ahmad Fatoum wrote:
> These scripts are all no-ops when nv.boot.default is set and that file
> in indeed set in the built-in environment shipped with DistroKit.
>
> They can thus be safely removed.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> .../barebox-am335x-defaultenv/init/bootsource | 11 -----------
> .../barebox-mx6-defaultenv/init/bootsource | 13 -------------
> .../barebox-rpi2-defaultenv/init/bootsource | 12 ------------
> .../barebox-vexpress-defaultenv/init/bootsource | 7 -------
> 4 files changed, 43 deletions(-)
> delete mode 100644 configs/platform-v7a/barebox-am335x-defaultenv/init/bootsource
> delete mode 100644 configs/platform-v7a/barebox-mx6-defaultenv/init/bootsource
> delete mode 100644 configs/platform-v7a/barebox-rpi2-defaultenv/init/bootsource
> delete mode 100644 configs/platform-v7a/barebox-vexpress-defaultenv/init/bootsource
>
> diff --git a/configs/platform-v7a/barebox-am335x-defaultenv/init/bootsource b/configs/platform-v7a/barebox-am335x-defaultenv/init/bootsource
> deleted file mode 100644
> index b3b73e790334..000000000000
> --- a/configs/platform-v7a/barebox-am335x-defaultenv/init/bootsource
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -#!/bin/sh
> -
> -if [ -n "$nv.boot.default" ]; then
> - exit
> -fi
> -
> -if [ $bootsource = mmc ]; then
> - global.boot.default="bootchooser net"
> -else
> - global.boot.default="net bootchooser"
> -fi
> diff --git a/configs/platform-v7a/barebox-mx6-defaultenv/init/bootsource b/configs/platform-v7a/barebox-mx6-defaultenv/init/bootsource
> deleted file mode 100644
> index 852cfd7d9611..000000000000
> --- a/configs/platform-v7a/barebox-mx6-defaultenv/init/bootsource
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -#!/bin/sh
> -
> -if [ -n "$nv.boot.default" ]; then
> - exit
> -fi
> -
> -if [ $bootsource = mmc ]; then
> - detect mmc$bootsource_instance
> - global.boot.default="bootchooser net"
> -else
> - global.boot.default="net bootchooser"
> -fi
> -
> diff --git a/configs/platform-v7a/barebox-rpi2-defaultenv/init/bootsource b/configs/platform-v7a/barebox-rpi2-defaultenv/init/bootsource
> deleted file mode 100644
> index 50f505f6266b..000000000000
> --- a/configs/platform-v7a/barebox-rpi2-defaultenv/init/bootsource
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -#!/bin/sh
> -
> -if [ -n "$nv.boot.default" ]; then
> - exit
> -fi
> -
> -if [ $bootsource = mmc ]; then
> - global.boot.default="bootchooser net"
> -else
> - global.boot.default="net bootchooser"
> -fi
> -
> diff --git a/configs/platform-v7a/barebox-vexpress-defaultenv/init/bootsource b/configs/platform-v7a/barebox-vexpress-defaultenv/init/bootsource
> deleted file mode 100644
> index 4432e021fb0f..000000000000
> --- a/configs/platform-v7a/barebox-vexpress-defaultenv/init/bootsource
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -#!/bin/sh
> -
> -if [ -n "$nv.boot.default" ]; then
> - exit
> -fi
> -
> -global.boot.default="bootchooser net"
> --
> 2.39.5
>
>
>
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
prev parent reply other threads:[~2025-04-22 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 10:28 Ahmad Fatoum
2025-04-14 10:28 ` [DistroKit] [PATCH 2/3] v7a: barebox: rename barebox.config to barebox-common.config Ahmad Fatoum
2025-04-14 10:28 ` [DistroKit] [PATCH 3/3] v7a: barebox: am335x: switch to using upstream rule Ahmad Fatoum
2025-04-22 9:24 ` Robert Schwebel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAdgT7yisK0loixs@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=distrokit@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox