From: Michael Olbrich <m.olbrich@pengutronix.de>
To: distrokit@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [DistroKit] [PATCH 2/3] tf-a-stm32mp13: use _URL and _SOURCE from tf-a
Date: Fri, 3 May 2024 14:06:19 +0200 [thread overview]
Message-ID: <ZjTTOwQFcqri786U@pengutronix.de> (raw)
In-Reply-To: <20240503-spotty-pesticide-f533094e5e02@thorsis.com>
On Fri, May 03, 2024 at 01:53:30PM +0200, Alexander Dahl wrote:
> Hei hei,
>
> Am Fri, May 03, 2024 at 12:58:43PM +0200 schrieb Michael Olbrich:
> > It's already the same source since version and md5 a shared. So make
> > sure the exact same file is used and downloaded only once.
> >
> > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > ---
> > configs/platform-v7a/rules/tf-a-stm32mp13.make | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/configs/platform-v7a/rules/tf-a-stm32mp13.make b/configs/platform-v7a/rules/tf-a-stm32mp13.make
> > index d8a7e92de073..137dc8de3204 100644
> > --- a/configs/platform-v7a/rules/tf-a-stm32mp13.make
> > +++ b/configs/platform-v7a/rules/tf-a-stm32mp13.make
> > @@ -19,8 +19,8 @@ TF_A_STM32MP13_VERSION := $(call ptx/config-version, PTXCONF_TF_A)
> > TF_A_STM32MP13_MD5 := $(call ptx/config-md5, PTXCONF_TF_A)
> > TF_A_STM32MP13 := tf-a-stm32mp13-$(TF_A_STM32MP13_VERSION)
> > TF_A_STM32MP13_SUFFIX := tar.gz
> > -TF_A_STM32MP13_URL := https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/snapshot/$(TF_A_STM32MP13_VERSION).$(TF_A_STM32MP13_SUFFIX)
> > -TF_A_STM32MP13_SOURCE := $(SRCDIR)/$(TF_A_STM32MP13).$(TF_A_STM32MP13_SUFFIX)
> > +TF_A_STM32MP13_URL = $(TF_A_URL)
> > +TF_A_STM32MP13_SOURCE = $(TF_A_SOURCE)
>
> As stated before: this does only work if TF_A is enabled in
> platformconfig. It will still break if TF_A_STM32MP13 is enabled, but TF_A
> is not. (This was already broken in that way before this change.)
But the tf-a version use also reused, so it already breaks right now. This
is nothing new. We should either share it all on nothing.
Michael
>
> Greets
> Alex
>
> > TF_A_STM32MP13_DIR := $(BUILDDIR)/$(TF_A_STM32MP13)
> > TF_A_STM32MP13_BUILDDIR := $(TF_A_STM32MP13_DIR)/build
> > TF_A_STM32MP13_BUILD_OOT := YES
> > --
> > 2.39.2
> >
> >
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-05-03 12:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 10:58 [DistroKit] [PATCH 0/3] tf-a-stm32mp13 cleanup Michael Olbrich
2024-05-03 10:58 ` [DistroKit] [PATCH 1/3] tf-a-stm32mp13: align variables Michael Olbrich
2024-05-27 16:19 ` Robert Schwebel
2024-05-03 10:58 ` [DistroKit] [PATCH 2/3] tf-a-stm32mp13: use _URL and _SOURCE from tf-a Michael Olbrich
2024-05-03 11:53 ` Alexander Dahl
2024-05-03 12:06 ` Michael Olbrich [this message]
2024-05-27 16:20 ` Robert Schwebel
2024-05-03 10:58 ` [DistroKit] [PATCH 3/3] tf-a-stm32mp13: don't use _BUILDDIR Michael Olbrich
2024-05-27 16:20 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjTTOwQFcqri786U@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=distrokit@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox