Re: [DistroKit] [PATCH 1/1] v8a: Add support for tq-ma93xxca

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Fabian,

On 4/22/25 10:54, Fabian Pflug wrote:
> A new board, with an IMX93 processor.
> 
> - Barebox patch has been send upstream
> - magic number ist choosen at reandom

Nitpick: chosen, random

> -if of_compatible -k radxa,rock3a tq,imx8mp-tqma8mpql-mba8mpxl; then
> +if of_compatible -k radxa,rock3a tq,imx8mp-tqma8mpql-mba8mpxl tq,imx93-tqma9352; then

When the bootsource patch land in a barebox release, we'll be able
to drop this init script, but for now this is ok.

> +CONFIG_HAB=y
> +CONFIG_AHAB=y

I think we should leave this disabled, until we start actually doing
verified boot in DistroKit.

> +CONFIG_USB_EHCI=y

Interesting. I thought the i.MX93 would use a USB 3.0 capable controller
like the i.MX8MP, but apparently it's not so.


> diff --git a/configs/platform-v8a/config/images/imx93.config b/configs/platform-v8a/config/images/imx93.config
> new file mode 100644
> index 0000000..bbdb232
> --- /dev/null
> +++ b/configs/platform-v8a/config/images/imx93.config
> @@ -0,0 +1,21 @@
> +image @IMAGE@ {
> +	hdimage {
> +		align = 1M
> +		partition-table-type = gpt
> +	}
> +	partition barebox {
> +		image = "@BAREBOX_IMAGE@"
> +		offset = 32k
> +		in-partition-table = false

Why not make it a proper GPT partition? I know we are not consistent
with that in existing boards, but for new board support, we should put
everything into a GPT partition from the get-go.

> +	}
> +	partition barebox-state {

Please add a barebox-environment partition as well with a comment that
it's currently unused as the environment comes from the SPI flash.

That way, we'll be able to just switch over to using environment on the
boot medium in future without changing the partition layout again.

> +		offset = 3M
> +		size = 1M
> +		partition-type-uuid = barebox-state
> +	}
> +	partition root-A {
> +		offset = 4M

If everything has a size and is described in the partition table, do
we still need the offset (except of course for the barebox partition).

> +Boot Media
> +----------
> +
> +Booting is available via multiple sources (Compare Table 6: Boot configuration i.MX 93 from .

from? missing rest of line?


> +Write the bootloader ``platform-v8a/images/barebox-tqma93xx.img`` to USB:

s/Write to/Upload via/

Maybe even add the full command:

  imx-usb-loader platform-v8a/images/barebox-tqma93xx.img

> +
> +.. code-block:: shell
> +
> +    platform-v8a/sysroot-host/bin/imx-usb-loader platform-v8a/images/barebox-tqma93xx.img
> +
> +In Barebox, set the default boot location to nfs:
> +
> +    nv boot.default: nfs://dude06//ptx/work/user/fpg/DistroKit/platform-v8a/root

Drop the colon, so it's an executable command.

FYI, you can also use the barebox /mnt/nfs automount:

  dude06$ ln -s /ptx/work/user/fpg/DistroKit/platform-v8a/root \
		~fpg/nfsroot/${global.hostname-from-barebox}
  barebox$ nv net.server=dude05
  barebox$ nv user=fpg
  barebox$ boot /mnt/nfs


> +replace the path to one, where you have compiled your Distrokit
> +
> +
> +Booting via SD-Card
> +~~~~~~~~~~~~~~~~~~~
> +
> +Write the image ``platform-v8a/images/tq-mba93xxca.img`` to a microSD card. Put the
> +microSD card into the TQMa93xxCA and boot it.
> +
> +
> +Serial Console
> +--------------
> +
> +The serial boot console is available via the microUSB Connector on the board.
> +It brings 4 UARTS, whereas the first is the Serial console used by kernel and bootloader.

Thanks for including docs.

Cheers,
Ahmad

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |