From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 23 May 2025 10:49:14 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uIO5a-001pzD-2m for lore@lore.pengutronix.de; Fri, 23 May 2025 10:49:14 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uIO5a-0002eq-8g; Fri, 23 May 2025 10:49:14 +0200 Received: from mail.thorsis.com ([217.92.40.78]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uIO5W-0002cQ-06; Fri, 23 May 2025 10:49:10 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0486D148789A; Fri, 23 May 2025 10:49:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1747990149; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=WJvWT7184hsDpOEP17lRo9KWOXNcKmrzsJCVAFlfVp8=; b=mUtFoo0NatdBDw60TKOGlYkjhMcraBYjJfe+CBxLwXO8OmrNDVdI5ZKcS23yscFW6ril0i t2Qd8uvKBUJFAYfgV5BzcFoiGA004CWOg7OOq2wdqN2E8sNymO/n+/zXKB9s86rWX1vhFu 4CsoxPfcINNpgbruTmFGA3PdBj8H/iCxTuCM0JJ0LF/CINsb6uNzkc8N9PMltHPAgc3DTN X/nsvhYGmQ1+l0hyvDJOOyTXvO/NSBT221wZxEEHNE6gJ2czQr05KTsRy2Syt4/me1JhNc Y9e1YjIw3ryvCUoByeLhIfT4Y/kJfjSWshcV+jwxAllrzN0epcmtyniJvV2azg== Date: Fri, 23 May 2025 10:49:04 +0200 From: Alexander Dahl To: Lars Schmidt Message-ID: <20250523-oxidation-impatient-e4414c0099c8@thorsis.com> Mail-Followup-To: Lars Schmidt , distrokit@pengutronix.de References: <20250523081049.1693633-1-l.schmidt@pengutronix.de> <20250523081049.1693633-6-l.schmidt@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250523081049.1693633-6-l.schmidt@pengutronix.de> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [DistroKit] [PATCH 05/12] tf-a: unify handling of firmware parts for barebox X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hello Lars, Am Fri, May 23, 2025 at 10:10:42AM +0200 schrieb Lars Schmidt: > Technically the firmware parts are coming out of tf-a. > This moves the handling of the extra files for barebox all to > the same place and makes maintenance easier. I also think this does not belong to the firmware-imx package, but to a separate package. I sent patches for this last year as part of a different series, but those were dropped without further explanation. See <20240425080303.171897-1-ada@thorsis.com> ff. for reference. (I did not resend the not-merged parts of that series however, maybe I should have done that.) FWIW, I think this should go into an extension of the barebox package, because it is barebox who wants to use those files, not the task of the tf-a package to distribute it to all packages requiring this. We have a bsp layer on top of DistroKit building U-Boot which also needs artifacts built by the tf-a package. Extend tf-a for U-Boot too? I'd say no, but instead create a package extension for U-Boot so both barebox and U-Boot can inject files from tf-a. Maybe I should just resend those remaining patches for better understanding what I mean. Greets Alex > > Signed-off-by: Lars Schmidt > --- > configs/platform-v8a/rules/firmware-imx.make | 7 ------- > configs/platform-v8a/rules/tf-a.barebox.make | 15 +++++++++++++++ > 2 files changed, 15 insertions(+), 7 deletions(-) > > diff --git a/configs/platform-v8a/rules/firmware-imx.make b/configs/platform-v8a/rules/firmware-imx.make > index 6b01af3..8a59b9f 100644 > --- a/configs/platform-v8a/rules/firmware-imx.make > +++ b/configs/platform-v8a/rules/firmware-imx.make > @@ -29,12 +29,6 @@ FIRMWARE_IMX_LICENSE_FILES := \ > # > # Firmware blobs for barebox > # > -ifdef PTXCONF_FIRMWARE_IMX > -BAREBOX_INJECT_FILES += imx8mm-bl31.bin:firmware/imx8mm-bl31.bin > -BAREBOX_INJECT_FILES += imx8mn-bl31.bin:firmware/imx8mn-bl31.bin > -BAREBOX_INJECT_FILES += imx8mp-bl31.bin:firmware/imx8mp-bl31.bin > -BAREBOX_INJECT_FILES += imx8mq-bl31.bin:firmware/imx8mq-bl31.bin > -BAREBOX_INJECT_FILES += imx93-bl31.bin:firmware/imx93-bl31.bin > ifdef PTXCONF_FIRMWARE_IMX_BOOTIMAGE_IMX8 > BAREBOX_INJECT_FILES += ddr/synopsys/lpddr4_pmu_train_1d_dmem.bin:firmware/lpddr4_pmu_train_1d_dmem.bin > BAREBOX_INJECT_FILES += ddr/synopsys/lpddr4_pmu_train_1d_imem.bin:firmware/lpddr4_pmu_train_1d_imem.bin > @@ -45,7 +39,6 @@ BAREBOX_INJECT_FILES += ddr/synopsys/ddr4_dmem_2d.bin:firmware/ddr4_dmem_2d.bin > BAREBOX_INJECT_FILES += ddr/synopsys/ddr4_imem_1d.bin:firmware/ddr4_imem_1d.bin > BAREBOX_INJECT_FILES += ddr/synopsys/ddr4_imem_2d.bin:firmware/ddr4_imem_2d.bin > endif > -endif > > # ---------------------------------------------------------------------------- > # Extract > diff --git a/configs/platform-v8a/rules/tf-a.barebox.make b/configs/platform-v8a/rules/tf-a.barebox.make > index 4c61af2..6e22cba 100644 > --- a/configs/platform-v8a/rules/tf-a.barebox.make > +++ b/configs/platform-v8a/rules/tf-a.barebox.make > @@ -2,4 +2,19 @@ ifdef PTXCONF_TF_A > ifneq ($(filter k3,$(call remove_quotes, $(PTXCONF_TF_A_PLATFORMS))),) > BAREBOX_INJECT_FILES += k3-bl31.bin:firmware/k3-bl31.bin > endif > +ifneq ($(filter imx8mq,$(call remove_quotes, $(PTXCONF_TF_A_PLATFORMS))),) > +BAREBOX_INJECT_FILES += imx8mq-bl31.bin:firmware/imx8mq-bl31.bin > +endif > +ifneq ($(filter imx8mm,$(call remove_quotes, $(PTXCONF_TF_A_PLATFORMS))),) > +BAREBOX_INJECT_FILES += imx8mm-bl31.bin:firmware/imx8mm-bl31.bin > +endif > +ifneq ($(filter imx8mn,$(call remove_quotes, $(PTXCONF_TF_A_PLATFORMS))),) > +BAREBOX_INJECT_FILES += imx8mn-bl31.bin:firmware/imx8mn-bl31.bin > +endif > +ifneq ($(filter imx8mp,$(call remove_quotes, $(PTXCONF_TF_A_PLATFORMS))),) > +BAREBOX_INJECT_FILES += imx8mp-bl31.bin:firmware/imx8mp-bl31.bin > +endif > +ifneq ($(filter imx93,$(call remove_quotes, $(PTXCONF_TF_A_PLATFORMS))),) > +BAREBOX_INJECT_FILES += imx93-bl31.bin:firmware/imx93-bl31.bin > +endif > endif > \ No newline at end of file > -- > 2.39.5 > >