From: Roland Hieber <rhi@pengutronix.de>
To: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH] datapartition: make it selectable
Date: Mon, 17 Jun 2024 11:24:03 +0200 [thread overview]
Message-ID: <20240617092403.sky4qlang6atjbgt@pengutronix.de> (raw)
In-Reply-To: <20240613-whenever-enduring-698a9b93370b@thorsis.com>
On Thu, Jun 13, 2024 at 09:31:27AM +0200, Alexander Dahl wrote:
> Hello Roland,
>
> Am Tue, Jun 11, 2024 at 12:27:56PM +0200 schrieb Roland Hieber:
> > The data partition is not needed for all aspects of the system, and
> > running systemd-repart to recreate it after writing a new image slows
> > the debugging cycle considerably. Make it de-selectable to speed up the
> > debugging process.
>
> +1 for the general idea.
>
> However I noticed two things when testing this:
>
> First: The datapartition package also targetinstalls the conf files
> for creating the root-B partition to /etc/repart.rc-once.d/ which is
> not created now anymore. I guess the idea of the patch was to avoid
> systemd-repart, but at least the commit message claims only the data
> partition create is skipped. Maybe installing those conf files in the
> datapartition package was an unfortunate mixup to begin with.
Good point. But no, the datapartition contained a similar setup before,
using sfdisk to create the partition, which somehow broke at some time
in the past. So I took that as an opportunity to create the other
partition in the same setup while porting it to systemd-repart. But I
think it would make sense now to rename the recipe in the next patch
iteration.
> Second: this is the second package now with category
> 'project_specific' which shows up directly at the top level in the
> menu (ptxdist menuconfig, the other one is rauc-udev). I would
> propose to use a submenu instead and move these DistroKit specific
> packages over there.
Good idea.
- Roland
> Greets
> Alex
>
> >
> > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > ---
> > rules/datapartition.in | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/rules/datapartition.in b/rules/datapartition.in
> > index 5b8c737fb8ad..152a60633658 100644
> > --- a/rules/datapartition.in
> > +++ b/rules/datapartition.in
> > @@ -1,7 +1,7 @@
> > ## SECTION=project_specific
> >
> > config DATAPARTITION
> > - tristate
> > + tristate "datapartition"
> > select RC_ONCE
> > select SYSTEMD
> > select SYSTEMD_REPART
> > --
> > 2.39.2
> >
> >
>
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2024-06-17 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 10:27 Roland Hieber
2024-06-13 7:31 ` Alexander Dahl
2024-06-17 9:24 ` Roland Hieber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617092403.sky4qlang6atjbgt@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=distrokit@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox