From: Roland Hieber <rhi@pengutronix.de>
To: distrokit@pengutronix.de
Subject: Re: [DistroKit] [ptxdist] [PATCH] ptxd_make_vcs_version: always use all Git tags
Date: Wed, 13 Dec 2023 17:49:54 +0100 [thread overview]
Message-ID: <20231213164954.dqqrull43flrvhuh@pengutronix.de> (raw)
In-Reply-To: <20230926-harmony-thursday-44ea6336278d@ifak-system.com>
Just FYI; I initially sent the PTXdist patch because my DistroKit
version in /etc/issue still showed something very old with a big number
behind it, like "2019.12.0-00529-g1938a270ab52", because the recent tags
in the Git repo were non-signed tags.
- Roland
On Tue, Sep 26, 2023 at 12:13:58PM +0200, Alexander Dahl wrote:
> Hello Roland,
>
> Am Tue, Sep 26, 2023 at 10:32:05AM +0200 schrieb Roland Hieber:
> > The short-circuit results in a preference of signed tags over non-signed
> > tags. In BSPs where non-signed tags exist (e.g. DistroKit-2023.09.0)
> > that are newer than the latest signed tag (e.g. DistroKit-2019.12.0),
> > this will always lead to an unnecessarily old tag being used.
>
> Maybe this thread from 2018 can help (been there, tried that):
>
> https://lore.ptxdist.org/ptxdist/20180907100105.nleg2qmttyahcmzm@pengutronix.de/
>
> Greets
> Alex
>
> >
> > Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > ---
> > Steffen, do you still know why you chose a plain "git describe" first?
> >
> >
> > scripts/lib/ptxd_make_vcs_version.sh | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/scripts/lib/ptxd_make_vcs_version.sh b/scripts/lib/ptxd_make_vcs_version.sh
> > index 69e486ab31a5..d59e1eba9872 100644
> > --- a/scripts/lib/ptxd_make_vcs_version.sh
> > +++ b/scripts/lib/ptxd_make_vcs_version.sh
> > @@ -7,8 +7,7 @@
> > #
> >
> > ptxd_make_vcs_version() {
> > - PTXDIST_VCS_VERSION="$(git describe 2>/dev/null || \
> > - git describe --always --tags 2>/dev/null)"
> > + PTXDIST_VCS_VERSION="$(git describe --always --tags 2>/dev/null)"
> >
> > if [ -z "${PTXDIST_VCS_VERSION}" ]; then
> > PTXDIST_VCS_VERSION="unknown"
> > --
> > 2.39.2
> >
> >
>
>
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
parent reply other threads:[~2023-12-13 16:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230926-harmony-thursday-44ea6336278d@ifak-system.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213164954.dqqrull43flrvhuh@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=distrokit@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox